[NayNay] Updating faucet amount #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unning into an issue with tape possibly, commented test out for now
frankiebee
reviewed
Oct 17, 2024
Comment on lines
+8
to
+11
| // Sending only 1e10 BITS does not allow user's to register after receiving funds | ||
| // there are limits in place to ensure user's are leftover with a certain balance in their accounts | ||
| // increasing amount send here, will allow user's to register right away | ||
| const amount = "20000000000" |
There was a problem hiding this comment.
good job writing docs!
frankiebee
approved these changes
Oct 17, 2024
Comment on lines
+8
to
+11
| // Sending only 1e10 BITS does not allow user's to register after receiving funds | ||
| // there are limits in place to ensure user's are leftover with a certain balance in their accounts | ||
| // increasing amount send here, will allow user's to register right away | ||
| const amount = "20000000000" |
There was a problem hiding this comment.
good job writing docs!
| @@ -7,4 +7,5 @@ export const FAUCET_PROGRAM_MOD_KEY = '5GWamxgW4XWcwGsrUynqnFq2oNZPqNXQhMDfgNH9x | |||
| // this is differnt from tests because the fauce that is live now was lazily deployed without schemas | |||
| // TO-DO: update this when faucet is deployed properly | |||
| export const TESTNET_PROGRAM_HASH = '0x12af0bd1f2d91f12e34aeb07ea622c315dbc3c2bdc1e25ff98c23f1e61106c77' | |||
| // Hash with max send of 1e10 | |||
| @@ -8,21 +8,18 @@ import { EntropyFaucet } from '../src/faucet/main' | |||
| import { LOCAL_PROGRAM_HASH } from '../src/faucet/utils' | |||
| import { EntropyAccount } from '../src/account/main' | |||
|
|
|||
| test('Faucet Tests', async t => { | |||
| async function setupAndFundFaucet (t, naynayEntropy) { | |||
There was a problem hiding this comment.
move this function into dev dir
There was a problem hiding this comment.
do this in a different pr though i'll merge this in now
Comment on lines
+97
to
+98
| // TODO: @naynay fix below test for register failing when only sending 1e10 bits | ||
| // test('Faucet Tests: Successfully send funds but cannot register', async t => { |
There was a problem hiding this comment.
should this also be an issue?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Proposed Changes
Testing
Screenshots (if applicable)
Additional Context
Checklist
CHANGELOG.mdentry.github.com:entropyxyz/entropy-docs, where necessary.